[webkit-reviews] review granted: [Bug 63305] [chromium] Divide by zero in TilingData : [Attachment 98449] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 27 02:00:22 PDT 2011


MORITA Hajime <morrita at google.com> has granted Adrienne Walker
<enne at google.com>'s request for review:
Bug 63305: [chromium] Divide by zero in TilingData
https://bugs.webkit.org/show_bug.cgi?id=63305

Attachment 98449: Patch
https://bugs.webkit.org/attachment.cgi?id=98449&action=review

------- Additional Comments from MORITA Hajime <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=98449&action=review

> Source/WebCore/platform/graphics/chromium/LayerTilerChromium.cpp:277
> +    if (!m_tilingData.totalSizeX() || !m_tilingData.totalSizeY() ||
m_updateRect.isEmpty() || !numTiles())

It looks numTiles() check is redundant because m_updateRect is empty. Is that
right?
r+ anyway because being careful is no bad...


More information about the webkit-reviews mailing list