[webkit-reviews] review denied: [Bug 63013] [EFL] Page Cache was not Enabled, (Enable Page Cache) : [Attachment 98662] patch for efl port back/forward cache enable

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied DongJae, KIM
<dongjae1.kim at samsung.com>'s request for review:
Bug 63013: [EFL] Page Cache was not Enabled,(Enable Page Cache)
https://bugs.webkit.org/show_bug.cgi?id=63013

Attachment 98662: patch for efl port back/forward cache enable
https://bugs.webkit.org/attachment.cgi?id=98662&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=98662&action=review

Informal review - on my side.

> Source/WebKit/efl/ewk/ewk_view.cpp:61
> +#include "HistoryItem.h"

Move above line to  #include "HistoryItem.h" as below,

37 #include "GraphicsContext.h"
38 #include "HistoryItem.h"
39 #include "HTMLElement.h"

> Source/WebKit/efl/ewk/ewk_view.cpp:4512
> +void ewk_view_frame_restore_cachedpage(Evas_Object* o, Evas_Object* frame)

I think ewk_view_cached_page_restore is better.