[webkit-reviews] review denied: [Bug 63347] DFG non-speculative JIT has potentially harmful speculations with respect to arithmetic operations. : [Attachment 98584] the patch (fixed review, style)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 25 19:24:38 PDT 2011


Gavin Barraclough <barraclough at apple.com> has denied Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 63347: DFG non-speculative JIT has potentially harmful speculations with
respect to arithmetic operations.
https://bugs.webkit.org/show_bug.cgi?id=63347

Attachment 98584: the patch (fixed review, style)
https://bugs.webkit.org/attachment.cgi?id=98584&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
Hey Filip, looks good now, but I think you missed a review comment, I believe
that in the case of UInt32ToNumber & ValueToNumber the result could be reusing
the operand's register?


More information about the webkit-reviews mailing list