[webkit-reviews] review denied: [Bug 63340] Lexer error messages are currently appalling : [Attachment 98602] Patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Juan C. Montemayor
<jmont at apple.com>'s request for review:
Bug 63340: Lexer error messages are currently appalling
https://bugs.webkit.org/show_bug.cgi?id=63340

Attachment 98602: Patch
https://bugs.webkit.org/attachment.cgi?id=98602&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=98602&action=review

> Source/JavaScriptCore/parser/Lexer.cpp:531
> +		       m_lexErrorMessage = "Only quote characters are allowed
after \\u";

\u can only be followed by a unicode character number, or a closing quote

> Source/JavaScriptCore/parser/Lexer.cpp:582
> +		   m_lexErrorMessage = "New-line or end of input is not allowed
here";

Unexpected EOF

> Source/JavaScriptCore/parser/Lexer.cpp:1119
> +	   m_lexErrorMessage = "Invalid character";

Should say what the character is -- and should possibly escape it if it's a
control character.

> LayoutTests/fast/js/basic-strict-mode-expected.txt:184
> +PASS 'use strict';5.f threw exception SyntaxError: Identifiers cannot start
with a number.

This error is bogus -- "Only digits may follow a decimal point" might be ebtter


> LayoutTests/fast/js/cyclic-proto-expected.txt:1
> +posix_spawn fatal error: 9!

This change is bogus