[webkit-reviews] review granted: [Bug 63336] Convert SVGPath to SVGAnimatorFactory concept : [Attachment 98605] Patch v4

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 63336: Convert SVGPath to SVGAnimatorFactory concept
https://bugs.webkit.org/show_bug.cgi?id=63336

Attachment 98605: Patch v4
https://bugs.webkit.org/attachment.cgi?id=98605&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98605&action=review

r=me with comments.

> Source/WebCore/svg/SVGAnimateElement.h:74
>  

You forgot to remove #include "SVGPathByteStream.h"

> Source/WebCore/svg/SVGAnimatedPath.cpp:121
> +    // No paced animations for strings.

Hehe, not strings but SVGPathSegLists :) Please fix the comment. Make it to a
FIXME, Opera supports it.