[webkit-reviews] review denied: [Bug 63336] Convert SVGPath to SVGAnimatorFactory concept : [Attachment 98595] Patch v3

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 63336: Convert SVGPath to SVGAnimatorFactory concept
https://bugs.webkit.org/show_bug.cgi?id=63336

Attachment 98595: Patch v3
https://bugs.webkit.org/attachment.cgi?id=98595&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98595&action=review

You forgot to edit WebCore.gyp. And please remove the unnecessary headers in
SVGAnimateElement.h/.cpp. Patch looks great btw :-)  r- because of the build
failure and the includes.

> Source/WebCore/svg/SVGAnimatedPath.cpp:39
> +PassOwnPtr<SVGAnimatedType>
SVGAnimatedPathAnimator::constructFromString(const String& string)
> +{
> +    OwnPtr<SVGPathByteStream> byteStream = SVGPathByteStream::create();
> +    SVGPathParserFactory::self()->buildSVGPathByteStreamFromString(string,
byteStream, UnalteredParsing);
> +    return SVGAnimatedType::createPath(byteStream.leakPtr());

Don't you think it might be more secure to release the
OwnPtr<SVGPathByteStream> here and pass an PassOwnPtr?
SVGAnimatedType::createPath might be used on other places in the future. We
should make sure that the caller does not forget, that it hasn't the ownership
anymore.