[webkit-reviews] review denied: [Bug 62482] Restore scroll position on page reloads scheduled by <meta http-equiv="refresh" content="XX"/> : [Attachment 96856] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Jun 25 11:10:57 PDT 2011
Adam Barth <abarth at webkit.org> has denied Robert Hogan <robert at webkit.org>'s
request for review:
Bug 62482: Restore scroll position on page reloads scheduled by <meta
http-equiv="refresh" content="XX"/>
https://bugs.webkit.org/show_bug.cgi?id=62482
Attachment 96856: Patch
https://bugs.webkit.org/attachment.cgi?id=96856&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96856&action=review
> Source/WebCore/dom/Document.cpp:2543
> + if (url == m_url.string())
Does this account properly for fragment identifiers?
> Source/WebCore/loader/NavigationScheduler.h:82
> + void scheduleReload(double delay, const String& url);
How is scheduleReload different from scheduleRefresh? Why does scheduleReload
take a url parameter? Surely a reload is just going to use the same URL that
the document already has, right?
More information about the webkit-reviews
mailing list