[webkit-reviews] review granted: [Bug 53627] Inspector highlight rect is wrong for contents of transformed iframes : [Attachment 98577] [PATCH] Part 2: Fix Fixed Position Content

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 53627: Inspector highlight rect is wrong for contents of transformed
iframes
https://bugs.webkit.org/show_bug.cgi?id=53627

Attachment 98577: [PATCH] Part 2: Fix Fixed Position Content
https://bugs.webkit.org/attachment.cgi?id=98577&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=98577&action=review

> Source/WebCore/rendering/RenderBlock.cpp:2747
> +    mapLocalToContainer(repaintContainer, false, false, transformState, 0);

You should give wasFixed a default value of 0 to avoid having to do this.

> Source/WebCore/rendering/RenderBox.h:433
> +    virtual void mapLocalToContainer(RenderBoxModelObject* repaintContainer,
bool fixed, bool useTransforms, TransformState&, bool* wasFixed) const;

use wasFixed = 0 here.

> Source/WebCore/rendering/RenderInline.h:133
> +    virtual void mapLocalToContainer(RenderBoxModelObject* repaintContainer,
bool fixed, bool useTransforms, TransformState&, bool* wasFixed) const;

And here.

> Source/WebCore/rendering/RenderObject.h:774
> +    virtual void mapLocalToContainer(RenderBoxModelObject* repaintContainer,
bool useTransforms, bool fixed, TransformState&, bool* wasFixed) const;

And here.

> Source/WebCore/rendering/RenderView.h:167
> +    virtual void mapLocalToContainer(RenderBoxModelObject* repaintContainer,
bool useTransforms, bool fixed, TransformState&, bool* wasFixed) const;

You get the drill.