[webkit-reviews] review denied: [Bug 48292] Fix LayoutTests/canvas/philip/tests/2d.composite.uncovered.fill.destination-atop.html : [Attachment 97758] Fixed the style issue

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Mustafizur Rahaman
<mustaf.here at gmail.com>'s request for review:
Bug 48292: Fix
LayoutTests/canvas/philip/tests/2d.composite.uncovered.fill.destination-atop.ht
ml
https://bugs.webkit.org/show_bug.cgi?id=48292

Attachment 97758: Fixed the style issue
https://bugs.webkit.org/attachment.cgi?id=97758&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97758&action=review

> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:1519
> +    // As per the HTML Canvas spec
(http://www.whatwg.org/specs/web-apps/current-work/complete/the-canvas-element.
html)
> +    // For source-atop, the expected behavior when S= Transparent(T) &
D=Opaque(O) or vice-versa
> +    // S = O, D= T =>Expected Canvas Color = T
> +    // S = T, D= O =>Expected Canvas Color = O => i.e. we don't need to
clear the Source => NO need for CompositeSourceAtop
> +    // But for destination-top,the expected behavior S= Transparent(T) &
D=Opaque(O) or vice-versa
> +    // S = O, D= T =>Expected Canvas Color = T
> +    // S = T, D= O =>Expected Canvas Color = T => i.e. we need to clear the
Source => Need for CompositeDestinationAtop

I don't think this comment is helpful, please remove it