[webkit-reviews] review granted: [Bug 63350] Short bug titles from TestFailures page give no indication which tests are failing : [Attachment 98530] Include the directory containing the failing tests in titles of bugs filed from TestFailures when all the tests won't fit

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 24 13:44:54 PDT 2011


David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 63350: Short bug titles from TestFailures page give no indication which
tests are failing
https://bugs.webkit.org/show_bug.cgi?id=63350

Attachment 98530: Include the directory containing the failing tests in titles
of bugs filed from TestFailures when all the tests won't fit
https://bugs.webkit.org/attachment.cgi?id=98530&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98530&action=review

r=me

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilit
ies.js:96
> +	   if (!splitPaths.every(function(splitPath) { return splitPath[i] ===
firstSplitPath[i] }))

That's a neat way to write the test!


More information about the webkit-reviews mailing list