[webkit-reviews] review granted: [Bug 63348] Bugs filed from TestFailures page should include links to Trac for suspect revisions : [Attachment 98529] Include links to Trac in bugs filed from TestFailures

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 63348: Bugs filed from TestFailures page should include links to Trac for
suspect revisions
https://bugs.webkit.org/show_bug.cgi?id=63348

Attachment 98529: Include links to Trac in bugs filed from TestFailures
https://bugs.webkit.org/attachment.cgi?id=98529&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98529&action=review

r=me

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewCo
ntroller.js:309
> +		   endOfFirstSentence += ' in r' + firstSuspectRevision + ' <'
+ this._trac.changesetURL(firstSuspectRevision) + '>';

Nit: I like revision links to include the "r", but maybe that's more trouble
than it's worth.