[webkit-reviews] review granted: [Bug 63332] Safari will quit unexpectedly when launching Safari in the first time (crash in initQTSecurityPolicyNoLocalToRemoteSiteAttribute) : [Attachment 98515] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 63332: Safari will quit unexpectedly when launching Safari in the first
time (crash in initQTSecurityPolicyNoLocalToRemoteSiteAttribute)
https://bugs.webkit.org/show_bug.cgi?id=63332

Attachment 98515: Patch
https://bugs.webkit.org/attachment.cgi?id=98515&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=98515&action=review

> Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:246
> +    // Check to see if QTKit >= 7.6.3 is installed, which defines
NoRemoteToLocal and NoLocalToRemote.
> +    // If not, just set NoCrossSite = YES, which does the same thing as
NoRemoteToLocal = YES and 
> +    // NoLocalToRemote = YES in QTKit < 7.6.3.

We don't actually check the QTKit version here, so it would probably be better
to say something like "... see if the current version of QTKit has
NoRemoteToLocal ..." instead.