[webkit-reviews] review denied: [Bug 63332] Safari will quit unexpectedly when launching Safari in the first time (crash in initQTSecurityPolicyNoLocalToRemoteSiteAttribute) : [Attachment 98511] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has denied Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 63332: Safari will quit unexpectedly when launching Safari in the first
time (crash in initQTSecurityPolicyNoLocalToRemoteSiteAttribute)
https://bugs.webkit.org/show_bug.cgi?id=63332

Attachment 98511: Patch
https://bugs.webkit.org/attachment.cgi?id=98511&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=98511&action=review

> Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:252
> +    if (QTSecurityPolicyNoRemoteToLocalSiteAttribute) {
> +	   [movieAttributes setValue:[NSNumber numberWithBool:NO]
forKey:QTSecurityPolicyNoCrossSiteAttribute];
> +	   [movieAttributes setValue:[NSNumber numberWithBool:YES]
forKey:QTSecurityPolicyNoRemoteToLocalSiteAttribute];
> +	   [movieAttributes setValue:[NSNumber numberWithBool:YES]
forKey:QTSecurityPolicyNoLocalToRemoteSiteAttribute];
> +    } else
> +	   [movieAttributes setValue:[NSNumber numberWithBool:YES]
forKey:QTSecurityPolicyNoCrossSiteAttribute];
> +

SOFT_LINK_POINTER asserts in a debug build. You might add a
SOFT_LINK_POINTER_OPTIONAL version that does not.