[webkit-reviews] review denied: [Bug 55987] input type=email and multiple is not compliant : [Attachment 98464] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Kentaro Hara <haraken at google.com>'s
request for review:
Bug 55987: input type=email and multiple is not compliant
https://bugs.webkit.org/show_bug.cgi?id=55987

Attachment 98464: Patch
https://bugs.webkit.org/attachment.cgi?id=98464&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98464&action=review

Thank you for working on this.
However, the code change is not enough. We should allow whitespace in
user-input, but we should not send whitespace on form submission and
HTMLInputElement::value should not return a string with whitespace.

Please see
http://www.whatwg.org/specs/web-apps/current-work/multipage/states-of-the-type-
attribute.html#e-mail-state

We need to override TextFieldInputType::sanitizeValue() to strip whitespace.

> LayoutTests/fast/forms/resources/ValidityState-typeMismatch-email.js:75
> +emailCheck("   a @p.com   ,	 b at p.com   ", true);
> +emailCheck("   a at p.com   ,	b @p.com   ", true);

We should have tests for space characters other than U+0020.
U+0009 U+000A U+000C U+000D should be stripped, and U+2003 and U+3000 should
not be stripped.

http://www.whatwg.org/specs/web-apps/current-work/multipage/common-microsyntaxe
s.html#space-character

> Source/WebCore/html/EmailInputType.cpp:-66
> -    if (value.isEmpty())
> -	   return false;

Why did you remove these lines?