[webkit-reviews] review granted: [Bug 58408] [chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor : [Attachment 98441] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Nat Duca
<nduca at chromium.org>'s request for review:
Bug 58408: [chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl
portions of threaded compositor
https://bugs.webkit.org/show_bug.cgi?id=58408

Attachment 98441: Patch
https://bugs.webkit.org/attachment.cgi?id=98441&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98441&action=review

R=me, some nits but looks mostly the same as before.

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.h:40
> +class CCLayerTreeHostClient {

nit: this should probably have a protected, virtual d'tor with an empty body so
we can get nice compile warnings if somebody implements CCLayerTreeHostClient
but forgets to declare a virtual d'tor

> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:37
> +public:
> +    virtual ~CCLayerTreeHostImplClient() { }

nit: i've learned the preferred pattern for client interfaces is to make the
d'tor protected

> Source/WebKit/chromium/src/WebViewImpl.cpp:1030
> -	   FrameView* view = webframe->frameView();
> +	  FrameView* view = webframe->frameView();

the diff makes it look like the indentation is messed up here, is it?

> Source/WebKit/chromium/src/WebViewImpl.cpp:2580
> +

spurious newline