[webkit-reviews] review granted: [Bug 63291] Add the ability to dynamically modify linked call sites : [Attachment 98416] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 23 15:28:00 PDT 2011
Gavin Barraclough <barraclough at apple.com> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 63291: Add the ability to dynamically modify linked call sites
https://bugs.webkit.org/show_bug.cgi?id=63291
Attachment 98416: Patch
https://bugs.webkit.org/attachment.cgi?id=98416&action=review
------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=98416&action=review
> Source/JavaScriptCore/jit/JITWriteBarrier.h:41
> +#define JITWriteBarrierFlag ((void*)2)
Per coding standard I guess this should really be a static_cast, though I'm not
sure that really improves anything in this case.
More information about the webkit-reviews
mailing list