[webkit-reviews] review denied: [Bug 63293] convert editing/deleting/5390681-2.html to dump-as-markup : [Attachment 98410] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 23 14:54:54 PDT 2011


Ryosuke Niwa <rniwa at webkit.org> has denied Wyatt Carss <wcarss at chromium.org>'s
request for review:
Bug 63293: convert editing/deleting/5390681-2.html to dump-as-markup
https://bugs.webkit.org/show_bug.cgi?id=63293

Attachment 98410: Patch
https://bugs.webkit.org/attachment.cgi?id=98410&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98410&action=review

> LayoutTests/ChangeLog:14
> +	   * editing/deleting/5390681-2.html:
> +	   * editing/deleting/5390681.html:

Please rename these files.

> LayoutTests/editing/deleting/5390681-2.html:4
> +<p id="description">This tests for a bug where expansion for smart delete
would not consider editable boundaries.  Only 'foo' should be deleted.	You
should see ' bar'. <b>There is a bug: while the non-editable space isn't
deleted, deletion inserts a placeholder when it shouldn't.</b></p>

Clearly, we're not inserting a placeholder anymore.  We should probably remove
that sentence.	r- due to this description.


More information about the webkit-reviews mailing list