[webkit-reviews] review denied: [Bug 63173] DFG non-speculative JIT lacks basic optimizations for GetById and GetByVal : [Attachment 98300] the patch (fixed review, fixed style)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 23 14:47:18 PDT 2011


Gavin Barraclough <barraclough at apple.com> has denied Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 63173: DFG non-speculative JIT lacks basic optimizations for GetById and
GetByVal
https://bugs.webkit.org/show_bug.cgi?id=63173

Attachment 98300: the patch (fixed review, fixed style)
https://bugs.webkit.org/attachment.cgi?id=98300&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
Hey Filip, sorry to be picky but Darin will be disappointed in me if I'm not.
:-)
WebKit coding style calls for full names, bar cases of very commonly idiomatic
abbreviations.	really 'slowPathTarg' has to be 'slowPathTarget'.  Sorry to
bounce your patch for two extra letter, but we should do this right.


More information about the webkit-reviews mailing list