[webkit-reviews] review granted: [Bug 63281] TestFailures page fetches build JSON for every build, which is slow and limits history to the last build master restart : [Attachment 98404] Avoid fetching JSON data when possible on TestFailures page to determine if old-run-webkit-tests exited early

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 63281: TestFailures page fetches build JSON for every build, which is slow
and limits history to the last build master restart
https://bugs.webkit.org/show_bug.cgi?id=63281

Attachment 98404: Avoid fetching JSON data when possible on TestFailures page
to determine if old-run-webkit-tests exited early
https://bugs.webkit.org/attachment.cgi?id=98404&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98404&action=review

r=me

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildb
ot.js:75
> +    resultsHTMLForBuildIncludesTooManyFailuresInfo: function(buildName) {

See next comment.

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builde
r.js:247
> +	   var resultsHTMLIncludesTooManyFailuresInfo =
this.buildbot.resultsHTMLForBuildIncludesTooManyFailuresInfo(buildName);

I don't like "Includes" in this variable name because that implies (just
reading the variable name) that this particular build has info about too many
failures.  How about using "Supports" instead of "Includes"?

var resultsHTMLSupportsTooManyFailuresInfo =
this.buildbot.resultsHTMLForBuildSupportsTooManyFailuresInfo(buildName);