[webkit-reviews] review granted: [Bug 63287] [GTK] [WebKit2] WebKitTestRunner does not properly load TestNetscapePlugin : [Attachment 98405] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 23 14:34:54 PDT 2011


Xan Lopez <xan.lopez at gmail.com> has granted Martin Robinson
<mrobinson at webkit.org>'s request for review:
Bug 63287: [GTK] [WebKit2] WebKitTestRunner does not properly load
TestNetscapePlugin
https://bugs.webkit.org/show_bug.cgi?id=63287

Attachment 98405: Patch
https://bugs.webkit.org/attachment.cgi?id=98405&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=98405&action=review

> Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp:79
> +    return g_filename_to_utf8(value, -1, 0, &bytesWritten, 0);

Should just pass 0 for bitesWritten?


More information about the webkit-reviews mailing list