[webkit-reviews] review granted: [Bug 63209] Make line breaking obey the -webkit-locale property : [Attachment 98368] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted mitz at webkit.org's request for
review:
Bug 63209: Make line breaking obey the -webkit-locale property
https://bugs.webkit.org/show_bug.cgi?id=63209

Attachment 98368: Patch
https://bugs.webkit.org/attachment.cgi?id=98368&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98368&action=review

I'm going to say r+, although not sharing cached iterators for empty
-webkit-locale and for one that happens to match user locale seems unfortunate
(as well as empty vs null).

> Source/WebCore/platform/text/TextBreakIteratorICU.cpp:122
> +private:
> +    LineBreakIteratorPool() { }

Should the class also be noncopyable?