[webkit-reviews] review denied: [Bug 63247] ASSERTION FAILED: m_shouldWaitForSyncReplies in Connection.cpp : [Attachment 98335] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 23 10:03:04 PDT 2011


Anders Carlsson <andersca at apple.com> has denied Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 63247: ASSERTION FAILED: m_shouldWaitForSyncReplies in Connection.cpp
https://bugs.webkit.org/show_bug.cgi?id=63247

Attachment 98335: Patch
https://bugs.webkit.org/attachment.cgi?id=98335&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
Not sure if this fix is correct. is m_shouldWaitForSyncReplies protected by a
mutex? Would it be better to check something in connectionDidClose, maybe
modify the assertion?


More information about the webkit-reviews mailing list