[webkit-reviews] review granted: [Bug 63248] [GTK] Install a custom X error handler in plugin process : [Attachment 98336] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 23 07:58:06 PDT 2011
Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 63248: [GTK] Install a custom X error handler in plugin process
https://bugs.webkit.org/show_bug.cgi?id=63248
Attachment 98336: Patch
https://bugs.webkit.org/attachment.cgi?id=98336&action=review
------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98336&action=review
> Source/WebKit2/PluginProcess/gtk/PluginProcessMainGtk.cpp:41
> + gchar errorMessage[64];
> + XGetErrorText(xdisplay, error->error_code, errorMessage, 63);
Is 64 enough here?
More information about the webkit-reviews
mailing list