[webkit-reviews] review granted: [Bug 63160] Web Inspector: [refacotring] extensions test: replace dispatchOnFrontend with a more generic evaluateOnFrontend() : [Attachment 98205] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 23 04:51:04 PDT 2011


Yury Semikhatsky <yurys at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 63160: Web Inspector: [refacotring] extensions test: replace
dispatchOnFrontend with a more generic evaluateOnFrontend()
https://bugs.webkit.org/show_bug.cgi?id=63160

Attachment 98205: patch
https://bugs.webkit.org/attachment.cgi?id=98205&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98205&action=review

> LayoutTests/http/tests/inspector/extensions-test.js:25
> +	   var reply = InspectorTest._replyToExtension.bind(null,
event.ports[0]);

Please add a comment that this variable may be used by the eval'ed code.


More information about the webkit-reviews mailing list