[webkit-reviews] review denied: [Bug 61974] [EFL] DRT: Add LayoutTestControllerEfl. : [Attachment 98178] Fix the return value for some functions which return JSValueRefs

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied Raphael Kubo da Costa
<kubo at profusion.mobi>'s request for review:
Bug 61974: [EFL] DRT: Add LayoutTestControllerEfl.
https://bugs.webkit.org/show_bug.cgi?id=61974

Attachment 98178: Fix the return value for some functions which return
JSValueRefs
https://bugs.webkit.org/attachment.cgi?id=98178&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98178&action=review

> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:57
> +void LayoutTestController::addDisallowedURL(JSStringRef url)

We usually omit argument names if they are not used in the function body.

> Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp:401
> +    char* tmpDirEnv = getenv("TMPDIR");
> +    if (!tmpDirEnv)
> +	   tmpDirEnv = getenv("TEMP");
> +    if (!tmpDirEnv)
> +	   tmpDirEnv = const_cast<char*>("/tmp");

It's a bad code.  We must not cast a string literal to char*.
The first patch used "const char*" for tmpDirEnv. It was better.