[webkit-reviews] review granted: [Bug 62443] Make dynamic annotations weak symbols and prevent identical code folding by the linker : [Attachment 96716] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Timur Iskhodzhanov
<timurrrr at google.com>'s request for review:
Bug 62443: Make dynamic annotations weak symbols and prevent identical code
folding by the linker
https://bugs.webkit.org/show_bug.cgi?id=62443

Attachment 96716: Patch
https://bugs.webkit.org/attachment.cgi?id=96716&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=96716&action=review

Looks ok.

> Source/JavaScriptCore/wtf/DynamicAnnotations.h:80
> +#   define WTF_DYNAMIC_ANNOTATIONS_ATTRIBUTE_WEAK

This
#   define
style isn't used elsewhere in WebKit as far as I know.