[webkit-reviews] review requested: [Bug 61931] WebKitTestRunner needs an implementation of setTextDirection : [Attachment 98321] Patch v3 (fixed a memory leak)

[bugzilla-daemon at webkit.org]

Hironori Bono <hbono at chromium.org> has asked  for review:
Bug 61931: WebKitTestRunner needs an implementation of setTextDirection
https://bugs.webkit.org/show_bug.cgi?id=61931

Attachment 98321: Patch v3 (fixed a memory leak)
https://bugs.webkit.org/attachment.cgi?id=98321&action=review

------- Additional Comments from Hironori Bono <hbono at chromium.org>
Greetings Jessie,

Thank you for your review and comment.

(In reply to comment #5)
> (From update of attachment 98127 [details])
> > Tools/DumpRenderTree/win/LayoutTestControllerWin.cpp:1577
> > +	 framePrivate->setTextDirection(directionBSTR);
> 
> Potential leak: where is directionBSTR freed?

Thank you for noticing this leak. I totally forgot calling SysFreeString(). I
have added a SysFreeString() call after this line.

Regards,

Hironori Bono