[webkit-reviews] review granted: [Bug 62069] Move file-choosing and icon-loading management to FileInputType : [Attachment 98314] Patch

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 62069: Move file-choosing and icon-loading management to FileInputType
https://bugs.webkit.org/show_bug.cgi?id=62069

Attachment 98314: Patch
https://bugs.webkit.org/attachment.cgi?id=98314&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98314&action=review

> Source/WebCore/html/HTMLInputElement.cpp:1273
> +    ASSERT(m_inputType->isFileUpload());
> +    m_inputType->receiveDroppedFiles(filenames);

InputType::receiveDroppedFiles() has ASSERT_NOT_REACHED().  So the assertion
here is redundant.

> Source/WebCore/html/HTMLInputElement.cpp:1279
> +    ASSERT(m_inputType->isFileUpload());
> +    return m_inputType->icon();

ditto.