[webkit-reviews] review denied: [Bug 63062] Add capture attribute for HTML Media Capture : [Attachment 98147] Patch v2 : fix "no new tests", remove macro

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 22 21:20:58 PDT 2011


Sam Weinig <sam at webkit.org> has denied Jongseok Yang <js45.yang at samsung.com>'s
request for review:
Bug 63062: Add capture attribute for HTML Media Capture
https://bugs.webkit.org/show_bug.cgi?id=63062

Attachment 98147: Patch v2 : fix "no new tests", remove macro
https://bugs.webkit.org/attachment.cgi?id=98147&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
I think my old comment still holds. Even if the API for this feature is on
<input type=file>, I see no reason for the implementation to go through the
FileChooser.  I would much rather see a new dedicated "capture" chooser, and
new chrome client calls.  It should also not use RenderFileUploadControl.


More information about the webkit-reviews mailing list