[webkit-reviews] review denied: [Bug 63193] convert editing/deleting/delete-select-all-00* to dumpAsText : [Attachment 98252] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 22 19:22:02 PDT 2011


Ryosuke Niwa <rniwa at webkit.org> has denied Wyatt Carss <wcarss at chromium.org>'s
request for review:
Bug 63193: convert editing/deleting/delete-select-all-00* to dumpAsText
https://bugs.webkit.org/show_bug.cgi?id=63193

Attachment 98252: Patch
https://bugs.webkit.org/attachment.cgi?id=98252&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98252&action=review

> LayoutTests/editing/deleting/delete-select-all-002-expected.txt:1
> +

We should have editing delegates.

> LayoutTests/editing/deleting/delete-select-all-002.html:45
> -runEditingTest();
> +runDumpAsTextEditingTest();

You can do that by passing "true" to runDumpAsTextEditingTest.


More information about the webkit-reviews mailing list