[webkit-reviews] review requested: [Bug 20797] add Settings entries for per-script/lang generic family : [Attachment 98269] patch updated per ap's comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 22 17:23:58 PDT 2011


Jungshik Shin <jshin at chromium.org> has asked  for review:
Bug 20797: add Settings entries for per-script/lang generic family
https://bugs.webkit.org/show_bug.cgi?id=20797

Attachment 98269: patch updated per ap's comments
https://bugs.webkit.org/attachment.cgi?id=98269&action=review

------- Additional Comments from Jungshik Shin <jshin at chromium.org>
Can you take another look? 

uscript.h from ICU 3.6 (it turned out that Mac OS 10.5 has ICU 3.6) is included
instead of one from ICU 4.6. 

And, style issues are fixed and ScriptCodesFromICU.h is included from
individual platform files.


More information about the webkit-reviews mailing list