[webkit-reviews] review granted: [Bug 63198] Use create() method for AsyncAudioDecoder::DecodingTask : [Attachment 98265] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 22 16:53:33 PDT 2011


David Levin <levin at chromium.org> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 63198: Use create() method for AsyncAudioDecoder::DecodingTask
https://bugs.webkit.org/show_bug.cgi?id=63198

Attachment 98265: Patch
https://bugs.webkit.org/attachment.cgi?id=98265&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98265&action=review

> Source/WebCore/webaudio/AsyncAudioDecoder.h:56
> +	   static OwnPtr<DecodingTask> create(ArrayBuffer* audioData, double
sampleRate, PassRefPtr<AudioBufferCallback> successCallback,
PassRefPtr<AudioBufferCallback> errorCallback);

PassOwnPtr :)

Filed bug https://bugs.webkit.org/show_bug.cgi?id=63204 (I'll have a patch up
soon.)


More information about the webkit-reviews mailing list