[webkit-reviews] review granted: [Bug 63198] Use create() method for AsyncAudioDecoder::DecodingTask : [Attachment 98264] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 63198: Use create() method for AsyncAudioDecoder::DecodingTask
https://bugs.webkit.org/show_bug.cgi?id=63198

Attachment 98264: Patch
https://bugs.webkit.org/attachment.cgi?id=98264&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98264&action=review

Feel free to do your move to the cpp file on checkin (and the chromium build
fix).

> Source/WebCore/webaudio/AsyncAudioDecoder.h:56
> +	   static OwnPtr<DecodingTask> create(ArrayBuffer* audioData, double
sampleRate, PassRefPtr<AudioBufferCallback> successCallback,
PassRefPtr<AudioBufferCallback> errorCallback)

Return type should be PassOwnPtr. (I thought we checked this, but if not, I'll
add a style check quickly.)