[webkit-reviews] review requested: [Bug 61442] [chromium] Red and Blue channels are swapped in images with accelerated drawing : [Attachment 98260] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 22 16:14:33 PDT 2011


Alok Priyadarshi <alokp at chromium.org> has asked  for review:
Bug 61442: [chromium] Red and Blue channels are swapped in images with
accelerated drawing
https://bugs.webkit.org/show_bug.cgi?id=61442

Attachment 98260: proposed patch
https://bugs.webkit.org/attachment.cgi?id=98260&action=review

------- Additional Comments from Alok Priyadarshi <alokp at chromium.org>
Addressed most of the comments.
- Renamed shader program.
- Included file where SK_B32_SHIFT is defined.
- Did not removed ensureEnabled() calls because I was not sure if they are
necessary. If they are not necessary we should remove them in a separate patch.


More information about the webkit-reviews mailing list