[webkit-reviews] review granted: [Bug 63109] SVG1.1SE test with pointer-events and invalid gradient fill fails : [Attachment 98162] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 22 13:06:20 PDT 2011
Nikolas Zimmermann <zimmermann at kde.org> has granted Rob Buis
<rwlbuis at gmail.com>'s request for review:
Bug 63109: SVG1.1SE test with pointer-events and invalid gradient fill fails
https://bugs.webkit.org/show_bug.cgi?id=63109
Attachment 98162: Patch
https://bugs.webkit.org/attachment.cgi?id=98162&action=review
------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
I think the idea is to move your modified test to eg
svg/custom/a-meaningful-name-for-this-test.svg, and leave the
interact-pointer-03-t.svg as-is in svg/W3C-SVG-1.1-SE/. We can immediately tell
which tests we fixed from SVG 1.1 2nd Edition, by looking into
svg/W3C-SVG-1.1-SE/. Each test present there works and if its interactive, it
has a test that excersises the dynamic parts somewhere else (in eg. svg/custom
for your case). Sounds reasonable?
I'm going to set r+, as the patch is fine, but please place the original W3C
test in svg/W3C-SVG-1.1-SE/ and your modified one in
svg/custom/pointer-events-invalid-fill.svg (for example).
More information about the webkit-reviews
mailing list