[webkit-reviews] review granted: [Bug 63140] IndexedDB: fix multiple issues in IDBDatabase.idl : [Attachment 98174] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 22 10:25:43 PDT 2011


Adam Barth <abarth at webkit.org> has granted Mark Pilgrim
<pilgrim at chromium.org>'s request for review:
Bug 63140: IndexedDB: fix multiple issues in IDBDatabase.idl
https://bugs.webkit.org/show_bug.cgi?id=63140

Attachment 98174: Patch
https://bugs.webkit.org/attachment.cgi?id=98174&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98174&action=review

> Source/WebCore/storage/IDBDatabase.idl:58
>	   // EventTarget interface
>	   void addEventListener(in DOMString type,
>				 in EventListener listener,
> -				 in boolean useCapture);
> +				 in [Optional] boolean useCapture);
>	   void removeEventListener(in DOMString type,
>				    in EventListener listener,
> -				    in boolean useCapture);
> +				    in [Optional] boolean useCapture);

There's some question about what the right thing here is globally, but I'm
pretty sure this is what we're going to end up with.  The only question is
whether we want to make that decision all-at-once or whether we want to convert
these piecemeal.  I think it's ok to convert them piecemeal.


More information about the webkit-reviews mailing list