[webkit-reviews] review granted: [Bug 63037] Make instantiation of legacy editing position more explicit : [Attachment 98002] createDeprecatedLegacyEditingPosition to createLegacyEditingPosition; fixed gtk build
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 22 09:33:26 PDT 2011
Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 63037: Make instantiation of legacy editing position more explicit
https://bugs.webkit.org/show_bug.cgi?id=63037
Attachment 98002: createDeprecatedLegacyEditingPosition to
createLegacyEditingPosition; fixed gtk build
https://bugs.webkit.org/attachment.cgi?id=98002&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=98002&action=review
> Source/WebCore/dom/Position.h:70
> + int value() { return m_offset; }
Maybe make this const?
> Source/WebCore/dom/Position.h:73
> + LegacyEditingOffset(int offset) : m_offset(offset) { }
Maybe make this explicit too?
More information about the webkit-reviews
mailing list