[webkit-reviews] review denied: [Bug 57604] Remove nonstandard noresize attribute from HTML FrameSet Element : [Attachment 98141] Patch after incorporating Darin's comments

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Mustafizur Rahaman
<mustaf.here at gmail.com>'s request for review:
Bug 57604: Remove nonstandard noresize attribute from HTML FrameSet Element
https://bugs.webkit.org/show_bug.cgi?id=57604

Attachment 98141: Patch after incorporating Darin's comments
https://bugs.webkit.org/attachment.cgi?id=98141&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=98141&action=review

> Source/WebCore/rendering/RenderFrameSet.cpp:170
> -    if (inside && frameSet()->noResize()
> -	       && !request.readOnly() && !result.innerNode()) {
> +    if (inside && !request.readOnly() && !result.innerNode()) {
>	   result.setInnerNode(node());
>	   result.setInnerNonSharedNode(node());
>      }

Since noResize is now always false, you should have removed this entire block,
not removed the noResize check.