[webkit-reviews] review granted: [Bug 61627] [GTK] Remove Connection::setShouldCloseConnectionOnProcessTermination() : [Attachment 95164] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 61627: [GTK] Remove
Connection::setShouldCloseConnectionOnProcessTermination()
https://bugs.webkit.org/show_bug.cgi?id=61627

Attachment 95164: Patch
https://bugs.webkit.org/attachment.cgi?id=95164&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95164&action=review

Great. :)

> Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:65
> +    int socket = GPOINTER_TO_INT(userData);
> +    close(socket);

This can be one line here.

> Source/WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:96
> +    // Monitor the child process, it calls waitpid to avoid the child
process to become a zombie,

avoid the child process to become a zombie -> prevent the child process from
becomming a zombie