[webkit-reviews] review granted: [Bug 62202] [ShadowContentElement] should layout child whitespace between span : [Attachment 97923] Updated expectations

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted MORITA Hajime
<morrita at google.com>'s request for review:
Bug 62202: [ShadowContentElement] should layout child whitespace between span
https://bugs.webkit.org/show_bug.cgi?id=62202

Attachment 97923: Updated expectations
https://bugs.webkit.org/attachment.cgi?id=97923&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97923&action=review

So it seems that we are compensating for the fact that we don't have the final
flattened tree concept (http://dev.w3.org/2006/xbl2/#the-final-flattened-tree).
Perhaps we should look at this problem from the overall design perspective and
solve it at that level. O(N) iterations like these always make me feel like
there's something missing in bigger picture.

> Source/WebCore/ChangeLog:9
> +	   ignored forward content tree hierarchies and used render-object

forwarded

> Source/WebCore/ChangeLog:13
> +	   In this way, these methods can reflect hierarchies of forward
(twilight) tree.

forwarded.

not twilight, right? Light tree I thought? Since we don't have either one
defined anywhere, let's just zap the reference to it.

> Source/WebCore/dom/NodeRenderingContext.cpp:111
> +    size_t currentIndex = notFound;
> +    for (size_t i = 0; i < parent->inclusionCount(); ++i) {
> +	   if (current == parent->inclusionAt(i)) {
> +	       currentIndex = i;
> +	       break;
> +	   }
> +    }

Sounds like this should be ShadowContentElement::indexOfInclusion.

> Source/WebCore/rendering/RenderTreeAsText.cpp:763
> +	   return ts.release();

Ouch.