[webkit-reviews] review granted: [Bug 63060] [GTK] Use GOption to parse main arguments in GtkLauncher : [Attachment 98144] Updated patch according to review

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 63060: [GTK] Use GOption to parse main arguments in GtkLauncher
https://bugs.webkit.org/show_bug.cgi?id=63060

Attachment 98144: Updated patch according to review
https://bugs.webkit.org/attachment.cgi?id=98144&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98144&action=review

Great stuff. it doesn't seem like settings will "stick" for other WebViews
opened unfortunatelyi. I guess we can fix that in a followup patch since it's
sort of unrelated to this.

> Tools/GtkLauncher/main.c:379
> +    static WebKitWebSettings *webkitSettings = 0;
> +#endif
> +    static const gchar **uriArguments = 0;
> +    static const GOptionEntry commandLineOptions[] =

If I'm not mistaken these do not have to be static. Please check before
landing.