[webkit-reviews] review granted: [Bug 57983] [Qt] media tests are flakey : [Attachment 98158] Skip only failing media tests

[bugzilla-daemon at webkit.org]

Nancy Piedra <nancy.piedra at nokia.com> has granted  review:
Bug 57983: [Qt] media tests are flakey
https://bugs.webkit.org/show_bug.cgi?id=57983

Attachment 98158: Skip only failing media tests
https://bugs.webkit.org/attachment.cgi?id=98158&action=review

------- Additional Comments from Nancy Piedra <nancy.piedra at nokia.com>
I downloaded the Qt Webkit VM to analyze the flakey media tests.

I modified the Skipped file to skip only those tests that failed outright on
the VM.

I then ran the layout tests many times and did not see any of the media tests
fail.  

With this set of tests I did not see any flakiness.  I'm not sure if this bug
was logged before or after the buildbot was upgraded to Qt Mobility 1.2 so it
is not clear to me what version of Qt Mobility was in place when the flakiness
was observerd.

In other words, I could not reproduce the flakiness in order to find a fix for
it but I could find a stable set of tests.