[webkit-reviews] review requested: [Bug 47971] css combinator "+" in combination with NAV tag is buggy : [Attachment 98129] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 22 00:47:00 PDT 2011


Chiculita Alexandru <achicu at adobe.com> has asked  for review:
Bug 47971: css combinator "+" in combination with NAV tag is buggy
https://bugs.webkit.org/show_bug.cgi?id=47971

Attachment 98129: Patch
https://bugs.webkit.org/attachment.cgi?id=98129&action=review

------- Additional Comments from Chiculita Alexandru <achicu at adobe.com>
Thank you for reviewing the patch. I've simplified the test and addressed all
the issues.

- You're right about #div+nav. It doesn't matter what's before "+nav" in the
selector. Just to make sure, I've also added another test for label+nav. 
- I've kept "one" and "two" IDs, because I need them in the selectors.
- I kept only two values in greenValues array. It looks like most of the latest
browsers return "rgb(0, 128, 0)" while Opera returns "#008000". It is easier to
compare the results with other browsers this way.


More information about the webkit-reviews mailing list