[webkit-reviews] review denied: [Bug 62914] Incorrectly placed SVG gradients can cause crashes when referenced : [Attachment 98061] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 21 23:08:29 PDT 2011


Nikolas Zimmermann <zimmermann at kde.org> has denied Jeffrey Pfau
<jeffrey at endrift.com>'s request for review:
Bug 62914: Incorrectly placed SVG gradients can cause crashes when referenced
https://bugs.webkit.org/show_bug.cgi?id=62914

Attachment 98061: Patch
https://bugs.webkit.org/attachment.cgi?id=98061&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98061&action=review

Almost perfect! I'd like to see another testcase, then I'll r+ it.

> LayoutTests/svg/custom/invalid-gradient-with-xlink.svg:10
> +	   layoutTestController.dumpAsText(true);

Great, dumpAsText + pixel test!

> Source/WebCore/rendering/svg/RenderSVGResourceGradient.cpp:160
> -	   collectGradientAttributes(gradientElement);
> +	   if (!collectGradientAttributes(gradientElement))
> +	       return false;
> +

Ok I made up my mind, this place is just fine as well, no need to dig into
SVGResourcesCycleSolver.

I'd like to request another testcase:
<defs>
    <linearGradient id="vallidGradient">
	 <stop offset=....
    </linearGradient>
 </defs>

<rect fill="url(#grad1) green">
    <linearGradient id="grad1" xlink:href="#validGradient"/>
</rect>

This should assure that invalidGradient -> validGradient, indirections are also
ignored.


More information about the webkit-reviews mailing list