[webkit-reviews] review denied: [Bug 63082] HTML parser should limit element depth of produced tree : [Attachment 98109] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 21 22:29:23 PDT 2011


Adam Barth <abarth at webkit.org> has denied Sam Weinig <sam at webkit.org>'s request
for review:
Bug 63082: HTML parser should limit element depth of produced tree
https://bugs.webkit.org/show_bug.cgi?id=63082

Attachment 98109: Patch
https://bugs.webkit.org/attachment.cgi?id=98109&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98109&action=review

I agree with mitz's comments.  Eric should verify that we're keeping track of
m_size properly.

> Source/WebCore/html/parser/HTMLConstructionSite.cpp:103
> +	   parent->parserAddChild(child);
> +    } else
> +	   parent->parserAddChild(child);

Should these lines go outside the if-block?


More information about the webkit-reviews mailing list