[webkit-reviews] review granted: [Bug 63107] Make sheriff-bot rollout messages a little nicer : [Attachment 98087] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 21 18:50:35 PDT 2011
Ojan Vafai <ojan at chromium.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 63107: Make sheriff-bot rollout messages a little nicer
https://bugs.webkit.org/show_bug.cgi?id=63107
Attachment 98087: Patch
https://bugs.webkit.org/attachment.cgi?id=98087&action=review
------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98087&action=review
> Tools/Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:82
> + # When folks pass junk arguments, we should just spit the usage back
at them.
This comment doesn't seem helpful.
> Tools/Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:89
> + # FIXME: I'm slightly confused as to why this doesn't return the
USAGE message.
It's not clear from the USAGE message that you can't begin your rollout
description with a dash.
More information about the webkit-reviews
mailing list