[webkit-reviews] review granted: [Bug 63092] input/textarea onchange doesn't fire if value is set in key listener : [Attachment 98086] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 21 17:44:07 PDT 2011


Darin Adler <darin at apple.com> has granted Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 63092: input/textarea onchange doesn't fire if value is set in key listener
https://bugs.webkit.org/show_bug.cgi?id=63092

Attachment 98086: Patch
https://bugs.webkit.org/attachment.cgi?id=98086&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=98086&action=review

> Source/WebCore/ChangeLog:15
> +	   * html/HTMLInputElement.cpp:
> +	   (WebCore::HTMLInputElement::setValue):
> +	   * html/HTMLTextAreaElement.cpp:
> +	   (WebCore::HTMLTextAreaElement::setValue):
> +	   (WebCore::HTMLTextAreaElement::setNonDirtyValue):
> +	   (WebCore::HTMLTextAreaElement::setValueCommon):

Could you add something to the change log that explains why these changes are
correct?

> Source/WebCore/html/HTMLInputElement.cpp:982
> +    String sanitizedValue = this->sanitizeValue(value);

Why the this-> on this line?


More information about the webkit-reviews mailing list