[webkit-reviews] review granted: [Bug 62050] add css parsing of flex() : [Attachment 98077] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 21 16:44:08 PDT 2011


Eric Seidel <eric at webkit.org> has granted Tony Chang <tony at chromium.org>'s
request for review:
Bug 62050: add css parsing of flex()
https://bugs.webkit.org/show_bug.cgi?id=62050

Attachment 98077: Patch
https://bugs.webkit.org/attachment.cgi?id=98077&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=98077&action=review

LGTM!

> Source/WebCore/css/CSSParser.cpp:788
> +	   return primitiveValueCache()->createValue(value->string,
(CSSPrimitiveValue::UnitTypes) value->unit);

We don't generally use C-style casts.  But you can land this as-is, especially
if you have any plans to clean up this primativeValueCache()->createValue
repetative nonsense throughout this file. :)


More information about the webkit-reviews mailing list