[webkit-reviews] review granted: [Bug 62181] Incorrect compositing overlap test : [Attachment 98065] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Adrienne Walker
<enne at google.com>'s request for review:
Bug 62181: Incorrect compositing overlap test
https://bugs.webkit.org/show_bug.cgi?id=62181

Attachment 98065: Patch
https://bugs.webkit.org/attachment.cgi?id=98065&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=98065&action=review

r=me but please consider renaming the method and tweaking the test.

> LayoutTests/compositing/layer-creation/overlap-transformed-layer.html:46
> +	   layoutTestController.dumpAsText(false);

I think pixel results would be useful here too (they can be cross-platform
since they don't contain text).

> LayoutTests/compositing/layer-creation/overlap-transformed-layer.html:50
> +	   layoutTestController.waitUntilDone();
> +	   window.addEventListener('load', function() {
> +	       document.getElementById("layertree").innerText =
layoutTestController.layerTreeAsText();
> +	       layoutTestController.notifyDone();

You don't need waitUntilDone/notifyDone when the test does work during the load
event.

> LayoutTests/compositing/layer-creation/overlap-transformed-layer.html:58
> +	   <!-- This red square should not be visible -->
> +	   <div id="red"></div>

I usually use #indicator for such elements.

> Source/WebCore/rendering/RenderLayerCompositor.cpp:572
> +void RenderLayerCompositor::addToOverlapMapRecursive(OverlapMap& overlapMap,
RenderLayer* layer)

I prefer the method name i suggested previously.