[webkit-reviews] review denied: [Bug 63023] [chromium] Searching may cause a segmentation fault in WebPluginDocument : [Attachment 97882] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 21 15:18:13 PDT 2011
Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Andrew Russell
<deadhead at google.com>'s request for review:
Bug 63023: [chromium] Searching may cause a segmentation fault in
WebPluginDocument
https://bugs.webkit.org/show_bug.cgi?id=63023
Attachment 97882: Patch
https://bugs.webkit.org/attachment.cgi?id=97882&action=review
------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=97882&action=review
The fix seems right, but why no test?
> Source/WebKit/chromium/ChangeLog:5
> + Searching may cause a segmentation fault in WebPluginDocument
This is way too sparse and cryptic to be useful. Can you perhaps enrich this a
bit with explanation of how this happens and why this is the right fix? The
commit archeologists thank you in advance :)
More information about the webkit-reviews
mailing list